Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

EIP-7702 Integration #108

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

EIP-7702 Integration #108

wants to merge 3 commits into from

Conversation

0xFirekeeper
Copy link
Member

@0xFirekeeper 0xFirekeeper commented Dec 18, 2024

Experimenting on Odyssey for now


PR-Codex overview

This PR introduces the implementation of the SignAuthorization method in multiple wallet classes, along with enhancements to transaction handling and utility functions related to EIP-7702 authorization.

Detailed summary

  • Added SignAuthorization method in EcosystemWallet (not implemented) and SmartWallet (delegates to personal account).
  • Introduced TrimZeroes utility method in Utils.cs.
  • Updated IThirdwebWallet interface to include SignAuthorization.
  • Enhanced ThirdwebTransaction to handle EIP-7702 authorization.
  • Added EIP7702Authorization struct for authorization data.
  • Modified SignTransaction in PrivateKeyWallet to support authorization list.
  • Updated console application to demonstrate the new authorization feature.

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

Experimenting on Odyssey for now
{
var authorization = transaction.Input.AuthorizationList[0];
hash = await rpc.SendRequestAsync<string>(
"wallet_sendTransaction",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

what wallet supports this rpc method currently?

also shouldnt that just be handled in side IThirdwebWallet.SendTransaction ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants