Add Enclave Wallet Functionality #820
Open
+228
−49
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dirtycajunrice
changed the title
| import { EnclaveWallet } from "thirdweb/dist/types/wallets/in-app/core/wallet/enclave-wallet"; | ||
| import { getUserStatus } from "thirdweb/dist/types/wallets/in-app/core/actions/get-enclave-user-status"; | ||
| import type { Ecosystem } from "thirdweb/dist/types/wallets/in-app/core/wallet/types"; | ||
| import { ClientScopedStorage } from "thirdweb/dist/types/wallets/in-app/core/authentication/client-scoped-storage"; |
There was a problem hiding this comment.
was there no way to just use inAppWallet() / ecosytemWallet for this?
can't really access these internal things like that. Might be worth exposing some of these if you need them, but probably with a bit higher level api
There was a problem hiding this comment.
Restating from internal for posterity: I have made the changes to use the preferred functions, however storage within the current design causes unintended results because it is not a browser environment, and will need to be addressed
dirtycajunrice
force-pushed
the
12-19-add-enclave-functionality
branch
from
50a87c6 to
cfccfc7
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
How this PR will be tested
Output
(Example: Screenshot/GIF for UI changes, cURL output for API changes)
PR-Codex overview
This PR introduces support for
EnclaveWalletfunctionality across various modules, enhancing transaction handling and account management by incorporating new types and parameters related to the enclave wallet.Detailed summary
MemoryStorageclass for async storage implementation.SendTransactionDatato includeenclaveparameter.doSimulateTransactionto acceptenclaveparameters.EnclaveWalletParamsinterface and related methods inget-enclave-wallet.getAccountto handleenclaveparameters.