Merge pull request #24 from thomasoca/fix-input-error

Fix input error
thomasoca · May 14, 2023 · 828e3a8 · 828e3a8
2 parents 27c32bb + b90c035
commit 828e3a8
Show file tree

Hide file tree

Showing 4 changed files with 21 additions and 4 deletions.
diff --git a/pkg/generator/latex.go b/pkg/generator/latex.go
@@ -15,6 +15,9 @@ func replaceUnescapedChar(str string) string {
 		"$", "{\\$}",
 		"{", "{\\{}",
 		"}", "{\\}}",
+		"\\", "{\\textbackslash}",
+		"^", "{\\textasciicircum}",
+		"~", "{\\textasciitilde}",
 	)
 
 	return s.Replace(str)

diff --git a/pkg/generator/latex_test.go b/pkg/generator/latex_test.go
@@ -0,0 +1,14 @@
+package generator
+
+import (
+	"testing"
+)
+
+func TestReplaceUnescapeChar(t *testing.T) {
+	test := `#$%&\_{}^~`
+	actual := replaceUnescapedChar(test)
+	expected := `{\#}{\$}{\%}{\&}{\textbackslash}{\_}{\{}{\}}{\textasciicircum}{\textasciitilde}`
+	if actual != expected {
+		t.Errorf("failed when replacing escape character, got: %s, expected: %s", actual, expected)
+	}
+}
diff --git a/pkg/image/image_test.go b/pkg/image/image_test.go
@@ -49,10 +49,10 @@ func TestIsUrl(t *testing.T) {
 	}
 }
 
-func TestIsDirectory(t *testing.T) {
+func TestIsFile(t *testing.T) {
 	path1 := "/home/thomasoca/Documents/important/foto.jpg"
 	check := IsImageFileExist(path1)
-	if check {
+	if !check {
 		t.Errorf("directory checking was incorrect, got: true, want: false")
 	}
 }
diff --git a/templates/template.tmpl b/templates/template.tmpl
@@ -128,7 +128,7 @@
 {{if $i}}
 \divider
 {{end}}
-\cvevent{{"{"}}{{.Position}}{{"}"}}{{"{"}}{{replaceUnescapedChar .Company}}{{"}"}}{{"{"}}{{.StartPeriod}} -- {{.EndPeriod}}{{"}"}}{{"{"}}{{.Location}}{{"}"}}
+\cvevent{{"{"}}{{replaceUnescapedChar .Position}}{{"}"}}{{"{"}}{{replaceUnescapedChar .Company}}{{"}"}}{{"{"}}{{.StartPeriod}} -- {{.EndPeriod}}{{"}"}}{{"{"}}{{.Location}}{{"}"}}
 {{if $it.Descriptions}}
 \begin{itemize}
 {{range $it.Descriptions}}
@@ -145,7 +145,7 @@
 {{if $i}}
 \divider
 {{end}}
-\cvevent{{"{"}}{{.Level}}, {{.Major}}{{if .Gpa}}, {{.Gpa}}{{end}}{{"}"}}{{"{"}}{{.Institution}}{{"}"}}{{"{"}}{{.StartPeriod}} -- {{.EndPeriod}}{{"}"}}{{"{"}}{{.Location}}{{"}"}}
+\cvevent{{"{"}}{{.Level}}, {{.Major}}{{if .Gpa}}, {{.Gpa}}{{end}}{{"}"}}{{"{"}}{{replaceUnescapedChar .Institution}}{{"}"}}{{"{"}}{{.StartPeriod}} -- {{.EndPeriod}}{{"}"}}{{"{"}}{{.Location}}{{"}"}}
 {{if $it.Descriptions}}
 \begin{itemize}
 {{range $it.Descriptions}}