Introduce GoldContainer data value
#39
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MatheusRich
commented
Oct 6, 2023
MatheusRich
force-pushed
the
mr/introduce-container-class
branch
from
e5697b3
to
92407db
Compare
MatheusRich
changed the title
Container data valueGoldContainer data value
MatheusRich
commented
Oct 6, 2023
| @@ -16,11 +16,11 @@ def mine_in(slack_channel, slack_client: GoldMiner::Slack::Client, env_file: ".e | |||
| .fmap { |client| explore(slack_channel, client) } | |||
| end | |||
|
|
|||
| def convert_messages_to_blogpost(channel, gold_nuggets, blog_post_builder: GoldMiner::BlogPost) | |||
| def convert_messages_to_blogpost(channel, container, blog_post_builder: GoldMiner::BlogPost) | |||
There was a problem hiding this comment.
I know the method name still says "messages", but I'll get rid of it soon.
A `GoldContainer` wraps gold nuggets, and has some metadata about them (origin and date of packing). There was a hidden dependency between the explorer and the blog post date (both using `Helpers::Time.last_friday`), but now their relation is explicit.
MatheusRich
force-pushed
the
mr/introduce-container-class
branch
from
92407db
to
ff2efa2
Compare
elias19r
approved these changes
Oct 9, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A
GoldContainerwraps gold nuggets, and has some metadata about them (origin and date of packing).There was a hidden dependency between the explorer and the blog post date (both using
Helpers::Time.last_friday), but now their relation is explicit.