WIP: make soundfont base url configurable #1040
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
felixroos
reviewed
Apr 1, 2024
packages/soundfonts/fontloader.mjs
Outdated
| soundfontUrl: 'https://felixroos.github.io/webaudiofontdata/sound' | ||
| } | ||
|
|
||
| export const fontloaderConfigMap = persistentMap('strudel-config-fontloader', defaultFontloaderConfig); |
There was a problem hiding this comment.
not sure if a persistentMap is best. wouldn't a simple global variable be enough? it would make sure the default fallback is used in the next session, so there is no hidden state stored in the browser. The fact that an alternative url is used would be visible in the code at all times
There was a problem hiding this comment.
you're right, I'll change that.
|
thanks! i guess this one's ready now? |
|
@fnordomat ok to merge? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.