bugfix: fix unittest assertion

tidb-incubator · Apr 1, 2024 · c600c84 · c600c84
1 parent a622379
commit c600c84
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 3 deletions.
diff --git a/tidb/src/main/java/io/tidb/bigdata/tidb/types/TimestampType.java b/tidb/src/main/java/io/tidb/bigdata/tidb/types/TimestampType.java
@@ -98,7 +98,7 @@ protected Timestamp decodeNotNullForBatchWrite(int flag, CodecDataInput cdi) {
   @Override
   public Object getOriginDefaultValue(String value, long version) {
     // avoid exception: org.joda.time.IllegalFieldValueException: Cannot parse "0000-00-00 00:00:00": Value 0 for monthOfYear must be in the range [1,12]
-    if (value != null && value.equals(TIMESTAMP_NULL_DEFAULT)) {
+    if (TIMESTAMP_NULL_DEFAULT.equals(value)) {
       value = null;
     }
     return super.getOriginDefaultValue(value, version);

diff --git a/tidb/src/test/java/io/tidb/bigdata/tidb/meta/TiColumnInfoTest.java b/tidb/src/test/java/io/tidb/bigdata/tidb/meta/TiColumnInfoTest.java
@@ -1,5 +1,7 @@
 package io.tidb.bigdata.tidb.meta;
 
+import static org.junit.Assert.assertEquals;
+
 import io.tidb.bigdata.tidb.types.TimestampType;
 import org.junit.Test;
 
@@ -15,12 +17,13 @@ public void testToProto() {
             TimestampType.TIMESTAMP,
             SchemaState.StatePublic,
             "0000-00-00 00:00:00",
-            "0000-00-00 00:00:00",
+            "2024-04-01 00:00:00",
             "0000-00-00 00:00:00",
             "timestamp",
             1,
             "",
             false);
-    System.out.println(columnInfo.getOriginDefaultValueAsByteString());
+    assertEquals(
+        "\000", columnInfo.getOriginDefaultValueAsByteString().toStringUtf8());
   }
 }