Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bugfix: fix exception Cannot parse "0000-00-00 00:00:00" #270

Merged
merged 4 commits into from
Apr 12, 2024

Conversation

lfyzjck
Copy link
Contributor

@lfyzjck lfyzjck commented Mar 28, 2024

…ps://github.com//issues/269

What is the purpose of the change

issue: #269
avoid exception Cannot parse "0000-00-00 00:00:00": Value 0 for monthOfYear must be in the range [1,12]

Brief change log

(for example:)

  • The TaskInfo is stored in the blob store on job creation time as a persistent artifact
  • Deployments RPC transmits only the blob storage reference
  • TaskManagers retrieve the TaskInfo from the blob cache

Verifying this change

(Please pick either of the following options)

This change is a trivial rework / code cleanup without any test coverage.

(or)

This change is already covered by existing tests, such as (please describe tests).

(or)

This change added tests and can be verified as follows:

(example:)

  • Added integration tests for end-to-end deployment with large payloads (100MB)
  • Extended integration test for recovery after master (JobManager) failure
  • Added test that validates that TaskInfo is transferred only once across recoveries
  • Manually verified the change by running a 4 node cluster with 2 JobManagers and 4 TaskManagers, a stateful streaming program, and killing one JobManager and two TaskManagers during the execution, verifying that recovery happens correctly.

Does this pull request potentially affect one of the following parts:

  • Dependencies (does it add or upgrade a dependency): no)
  • The public API: (no)
  • The runtime per-record code paths (performance sensitive): (yes)

Documentation

  • Does this pull request introduce a new feature? (yes / no)
  • If yes, how is the feature documented? (not applicable / docs / JavaDocs / not documented)

@CLAassistant
Copy link

CLAassistant commented Mar 28, 2024

CLA assistant check
All committers have signed the CLA.

@humengyu2012
Copy link
Collaborator

/run-all-tests

1 similar comment
@humengyu2012
Copy link
Collaborator

/run-all-tests

@humengyu2012 humengyu2012 force-pushed the fix_timetamp_default branch from 814c60f to 1d8de76 Compare April 12, 2024 06:36
@humengyu2012
Copy link
Collaborator

/run-all-tests

Copy link
Collaborator

@humengyu2012 humengyu2012 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@humengyu2012 humengyu2012 merged commit 22a3a86 into tidb-incubator:master Apr 12, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants