-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CDX 1.4, Initial support #126
Conversation
38c369e
to
b9da1dd
Compare
Not sure why this wasn't failing before, but one of the tests:
This seems to align with the upstream spec: https://cyclonedx.org/docs/1.4/json/#metadata_properties_items_value |
b9da1dd
to
ab5e04d
Compare
> Not sure why this wasn't failing before, but one of the tests: I also notice grype doesn't like the Please see the two commits I added on top of yours in #129, which gets rid of this problem. Also, they fix the github tests and makes them check the schema matches cdx 1.4. Feel free to cherry-pick or just copy the necessary parts of the changes from #129 to this PR if it helps. |
Yea, the commits look fine to me |
This is to avoid strong cycles between sbomdb.py and vulnscan.py Signed-off-by: Jonathan Ringer <jringer@anduril.com>
Signed-off-by: Jonathan Ringer <jringer@anduril.com>
Signed-off-by: Jonathan Ringer <jringer@anduril.com>
Signed-off-by: Henri Rosten <henri.rosten@unikie.com>
- Changes required to make the tests pass with the changes from PR#126 - Change the SbomDb so that vulnerabilities-section is added to the cdx sbom only if the argument `include_vulns` is set to True Signed-off-by: Henri Rosten <henri.rosten@unikie.com>
4fe1bb8
to
04e9382
Compare
Thanks for fixing up the tests, and making vulnerabilities optional :) |
Get vulnerabilities enumerated for CDX 1.4 scans.
I did check this was CDX 1.4 compliant (which it is), but still missing a
signatures
field. However, a lot of CDX additions are optional. And support for signatures can be added later.