Sbomnix refactor #95
Merged
Sbomnix refactor #95
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Henri Rosten <henri.rosten@unikie.com>
Signed-off-by: Henri Rosten <henri.rosten@unikie.com>
flokli
reviewed
Nov 29, 2023
henrirosten
force-pushed
the
sbomnix-refactor
branch
from
dea08ff
to
8c85bcc
Compare
flokli
reviewed
Nov 29, 2023
- Make it possible to call repology-related code from the repology package. - Change vulnxscan and nix_outdated so they call the replogoy-related code from the repology package instead of creating a new process with exec_cmd to invoke repology_cli or repology_cve. Signed-off-by: Henri Rosten <henri.rosten@unikie.com>
Signed-off-by: Henri Rosten <henri.rosten@unikie.com>
henrirosten
force-pushed
the
sbomnix-refactor
branch
from
8c85bcc
to
ecf9b87
Compare
flokli
approved these changes
Nov 30, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactor sbomnix so all pytests can be re-enabled:
scripts/tosrc/.vulnxscanandnix_outdatedso they call the repology-related code from the repology package instead of creating a new process withexec_cmdto invokerepology_cliorrepology_cve.In addition:
More cleanup/refactor PRs will follow, this is the first take.