Add masterminds/html5 #210
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stof
reviewed
May 17, 2021
src/CssToInlineStyles.php
Outdated
| */ | ||
| protected function parseHtml5($html) | ||
| { | ||
| $this->isHtml5Document = strspn($html, " \t\r\n") === stripos($html, '<!doctype html>'); |
There was a problem hiding this comment.
this looks wrong to me. It is still using the HTML5 parser even when this is false
There was a problem hiding this comment.
I think the way I implemented is the same as symfony/dom-crawler. It did seem a little odd to me. I'll change it if you want?
There was a problem hiding this comment.
I was looking at an old version. I've updated it 👍
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds optional usage of
masterminds/html5similar to the implementation insymfony/dom-crawler. This resolves some quirks when saving HTML documents withDOMDocumentfor example an anchor wrapping a table<a><table></table></a>becomes<table></table><a></a>Opt-in usage - pass
trueto the constructor argument. This differs tosymfony/dom-crawlerfor the sake of backwards compatibility i.e. users who already havemasterminds/html5as a project dependencyCloses #195