Use run ID instead of date prefix for resource naming. #26
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, all runs had been identified by the planet date they're generated from. This leads to problems when we want to run two concurrent, different runs off the same planet. To make sure resources are unique to the run rather than the planet file, this PR changes to name resources using the run ID instead. The previous behaviour should be (almost) emulated by specifying the run ID as `YYMMDD`. There are a few things, notably PostgreSQL database names, which used a `YYYY-MM-DD` format instead, and these will be incompatible. However, I think the gain is worth the hassle of having to manually go back and correct any of those which might still be running.
rmarianski
approved these changes
Sep 25, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, all runs had been identified by the planet date they're generated from. This leads to problems when we want to run two concurrent, different runs off the same planet. To make sure resources are unique to the run rather than the planet file, this PR changes to name resources using the run ID instead. The previous behaviour should be (almost) emulated by specifying the run ID as
YYMMDD.There are a few things, notably PostgreSQL database names, which used a
YYYY-MM-DDformat instead, and these will be incompatible. However, I think the gain is worth the hassle of having to manually go back and correct any of those which might still be running.Possibly helps towards #16.