Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tile size: water only changes #2010

Merged
merged 10 commits into from
Dec 16, 2021
Merged

Tile size: water only changes #2010

Changes from 1 commit
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
a09c026
water only changes
nvkelso Nov 19, 2021
334df35
fixing ws issues
tgrigsby-sc Nov 20, 2021
405361c
already range bound
nvkelso Dec 14, 2021
534b31a
fix integ tests errors(not failures)
peitilisc Dec 15, 2021
b078b0f
fix one integ test failure
peitilisc Dec 15, 2021
47cf4ce
fix test integration-test.1838-too-many-bays.BayTest.test_bays
peitilisc Dec 15, 2021
f5dafd3
more integ fixes
peitilisc Dec 15, 2021
77e663c
Address PR comments
nvkelso Dec 16, 2021
cc8be28
Drop all the old_name water instances
nvkelso Dec 16, 2021
0e79138
fix integ tests
peitilisc Dec 16, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions integration-test/1838-too-many-bays.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,9 +33,9 @@ def _bay(osm_id, area, name):
)

with self.features_in_tile_layer(z, x, y, 'water') as features:
# should only have top 10 features
self.assertEqual(10, len(features))
# should only have top 2 features
self.assertEqual(2, len(features))
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

At zoom 8 our area threshold for labels is 500,000,000 (was 200,000,000) and for polygons it's still 20000000.

Under the earlier system 5 meet the area threshold, but after only 2 do. So the changes here make sense to me.


# check that they're in order
ranks = [f['properties']['kind_tile_rank'] for f in features]
self.assertEqual(range(1, 11), ranks)
self.assertEqual(range(1, 3), ranks)