Restore early lake labels, add kind_detail for lakes and etc #2047
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
there is a linter violations, you might want to fix them using the pre-commit |
|
I am not sure why but the integration tests always failed with context deadline exceed. |
peitili
reviewed
Jan 28, 2022
nvkelso
commented
Jan 28, 2022
nvkelso
commented
Jan 28, 2022
nvkelso
commented
Jan 28, 2022
nvkelso
commented
Jan 28, 2022
nvkelso
commented
Jan 28, 2022
nvkelso
commented
Jan 28, 2022
nvkelso
commented
Jan 28, 2022
nvkelso
commented
Jan 28, 2022
nvkelso
commented
Jan 28, 2022
nvkelso
commented
Jan 28, 2022
nvkelso
changed the title
peitili
reviewed
Jan 28, 2022
peitili
reviewed
Jan 28, 2022
nvkelso
commented
Jan 28, 2022
nvkelso
commented
Jan 28, 2022
peitili
reviewed
Jan 29, 2022
nvkelso
commented
Jan 31, 2022
nvkelso
commented
Jan 31, 2022
nvkelso
commented
Jan 31, 2022
| @@ -9471,6 +9470,9 @@ def update_min_zoom(ctx): | |||
| local = defaultdict(lambda: None) | |||
| local.update(props) | |||
| local['zoom'] = zoom | |||
| # this is to make the name `properties` visible in the queries.yaml's | |||
| # where clause | |||
| local['properties'] = props | |||
There was a problem hiding this comment.
This may impact build time, but generally makes things more consistent and obvious.
Top level it's grouped with lake
peitili
force-pushed
the
nvkelso/water-lake-labels-fix
branch
from
0b54f17
to
912b486
Compare
peitili
approved these changes
Feb 1, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Connects with #2003 and followup of #2010 to restore "lake" water labels at low zooms.
Also non-breaking change implementation of #984 for the v1.x series (which should stay open as a separate breaking change for v2.x series).