Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

more rigorous countries labels per ISO and point-of-view #2069

Merged
merged 66 commits into from
May 24, 2022

Conversation

jeffdefacto
Copy link
Contributor

@jeffdefacto jeffdefacto commented Apr 20, 2022

This adds sql to alter the tlc table to edit the featurecla column to mark certain geounits as country or unrecognized. OSM labels that match with unrecognized countries or are a non match will return as kind=unrecognized at min zoom 8.

Countries updated as unrecognized

  • Akrotiri Sovereign Base Area
  • Ashmore and Cartier Islands
  • Clipperton Island
  • Coral Sea Islands
  • Dhekelia Cantonment
  • Somaliland
  • Turkish Republic of Northern Cyprus
  • Palestine (see Gaza Strip and West Bank instead)

Countries updated to Admin-0 dependency

  • Gaza Strip
  • Svalbard
  • West Bank

Newly rendering countries from data, lua, and sql improvements

  • Aland
  • American Samoa
  • Bermuda
  • Bouvet Island
  • Christmas Island
  • Cocos (Keeling) Islands
  • French Polynesia
  • French Southern and Antarctic Lands
  • Guam
  • Heard Island and McDonald Islands
  • Hong Kong
  • Macau
  • New Caledonia
  • Norfolk Island
  • Northern Mariana Islands
  • Puerto Rico
  • Réunion
  • Saint Helena, Ascension and Tristan da Cunha
  • Saint Barthélemy
  • Saint Martin (France)
  • Saint Pierre and Miquelon
  • Sāmoa
  • São Tomé and Príncipe
  • Svalbard
  • United States Minor Outlying Islands

@nvkelso
Copy link
Member

nvkelso commented Apr 28, 2022

Relates to:

#2075, #2076, #2077.

Copy link
Member

@nvkelso nvkelso left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please list out which labels this suppresses (as unrecognized) and which labels it adds or otherwise changes.

osm2pgsql.lua Outdated Show resolved Hide resolved
@nvkelso
Copy link
Member

nvkelso commented May 20, 2022

Please also list out in the PR description the country labels this adds (eg made changes in OSM / patches / LUA / SQL).

@nvkelso
Copy link
Member

nvkelso commented May 21, 2022

Please ensure that all the countries are listed here, otherwise they'll come out "unrecognized" in high zooms for RAWR:

Because of:

Specifically:

place cc min_zoom max_zoom
Martinique MQ 5 10
Tuvalu TV 5 10
Réunion RE 5 10
Cook Islands CK 4 9
Marshall Islands MH 5 10
Palau PW 5 10
Tokelau TK 5 10
Cayman Islands KY 5 9.5
Guadeloupe GP 5 10
British Indian Ocean Territory IO 5 9.5
Mayotte YT 5 10
French Southern and Antarctic Lands TF 4.5 9.5
French Guiana GF 5 10
France FR 1.7 6.7
Norway NO 3 7
Federated States of Micronesia FM 5 10
Solomon Islands SB 3 8

@nvkelso nvkelso changed the title hide countries not in NE more rigorous countries labels per ISO and point-of-view May 21, 2022
@jeffdefacto jeffdefacto merged commit afcf5c9 into master May 24, 2022
@jeffdefacto jeffdefacto deleted the junderwood/hide_non_ne_countries branch May 24, 2022 03:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants