Add query index params #10
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
These parameters to search() let you control the query-time parameters for index operations. They allow you to adjust the speed/recall tradeoff when querying. If these parameters aren't specified the default for the index will be used.
jgpruitt
reviewed
Nov 21, 2023
| @@ -1910,6 +1977,11 @@ | |||
| " (query, params) = self.builder.search_query(\n", | |||
| " query_embedding_np, limit, filter, predicates, uuid_time_filter)\n", | |||
| " query, params = self._translate_to_pyformat(query, params)\n", | |||
| "\n", | |||
| " if query_params is not None:\n", | |||
| " prefix = \"; \".join(query_params.get_statements())\n", | |||
There was a problem hiding this comment.
In the async client, we run each SET LOCAL separately, and in the sync we are concatenating. Does the asyncpg just not support this behavior?
jgpruitt
approved these changes
Nov 21, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These parameters to search() let you control the query-time parameters for index operations. They allow you to adjust the speed/recall tradeoff when querying.
If these parameters aren't specified the default for the index will be used.