Add option to specify the schema for the table #26
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jgpruitt
approved these changes
Aug 19, 2024
| @@ -80,6 +80,9 @@ The client constructor takes three required arguments: | |||
| | table_name | Name of the table to use for storing the embeddings. Think of this as the collection name | | |||
| | num_dimensions | Number of dimensions in the vector | | |||
|
|
|||
| You can also specify the schema name, distance type, primary key type, | |||
There was a problem hiding this comment.
Why not adding it to the table above with a column marking it as optional?
There was a problem hiding this comment.
I want to keep this part as simple as possible
alejandrodnm
approved these changes
Aug 20, 2024
| @@ -805,7 +820,7 @@ def __init__( | |||
| The type of the id column. Can be either 'UUID' or 'TEXT'. | |||
| """ | |||
| self.builder = QueryBuilder( | |||
| table_name, num_dimensions, distance_type, id_type, time_partition_interval, infer_filters) | |||
| table_name, num_dimensions, distance_type, id_type, time_partition_interval, infer_filters, schema_name) | |||
There was a problem hiding this comment.
Need to add schema_name to the docs. Would it make it easier if instead of None we default to "public"? That way we don't have to do the if self.schema_name is not None checks.
There was a problem hiding this comment.
None and public are not the same since public is not always the default schema. None means use the default schema defined by the db
| @@ -787,6 +801,7 @@ def __init__( | |||
| time_partition_interval: Optional[timedelta] = None, | |||
| max_db_connections: Optional[int] = None, | |||
| infer_filters: bool = True, | |||
| schema_name: Optional[str] = None, | |||
There was a problem hiding this comment.
Need to add this to the constructor docs
alejandrodnm
approved these changes
Aug 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.