fix: Fix mjml builtin attributes/tags

timo-reymann · Apr 5, 2021 · 7731c42 · 7731c42
1 parent 64b3a23
commit 7731c42
Show file tree

Hide file tree

Showing 3 changed files with 7 additions and 2 deletions.
diff --git a/src/main/kotlin/de/timo_reymann/mjml_support/model/BuiltInMjmlTagInformationProvider.kt b/src/main/kotlin/de/timo_reymann/mjml_support/model/BuiltInMjmlTagInformationProvider.kt
@@ -700,7 +700,7 @@ class BuiltInMjmlTagInformationProvider : MjmlTagInformationProvider() {
                         "center"
                     ),
                     MjmlAttributeInformation(
-                        "base url",
+                        "base-url",
                         MjmlAttributeType.STRING,
                         "base url for children components"
                     ),

diff --git a/src/main/kotlin/de/timo_reymann/mjml_support/model/constants_attributes.kt b/src/main/kotlin/de/timo_reymann/mjml_support/model/constants_attributes.kt
@@ -169,7 +169,7 @@ val ATTRIBUTE_HEIGHT = MjmlAttributeInformation(
 
 val ATTRIBUTE_WIDTH = MjmlAttributeInformation(
     "width",
-    MjmlAttributeType.PIXEL,
+    MjmlAttributeType.STRING,
     "width for element"
 )
 

diff --git a/src/main/resources/META-INF/plugin.xml b/src/main/resources/META-INF/plugin.xml
@@ -90,6 +90,11 @@
                     <li>Add extension point support</li>
                 </ul>
             </li>
+            <li>1.4.1
+                <ul>
+                    <li>Fix some attributes/tags - mjml documentation is very inconsistent here</li>
+                </ul>
+            </li>
         </ul>
         ]]></description>