Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add challenge filtering #17

Open
wants to merge 7 commits into
base: main
Choose a base branch
from
Open

Add challenge filtering #17

wants to merge 7 commits into from

Conversation

DaMrNelson
Copy link
Contributor

Allow the user to filter by DLC, survivor, item type, or artifacts using the UI.

image

@DaMrNelson DaMrNelson changed the title Add challange filtering Add challenge filtering Aug 31, 2024
tjosepo
tjosepo approved these changes Aug 31, 2024
View reviewed changes
Copy link
Owner

@tjosepo tjosepo left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good! This was a feature I wanted to do for a very long time, so I'm glad you're doing it! 🚀

Left a few comments. I think the logic could probably be simpified a bit, but I'm fine with how it looks right now.

(Sorry about preview deploys not working properly, I'm still figuring out Github Actions 😅)

src/components/editor.tsx Outdated Show resolved Hide resolved
src/components/editor.tsx Outdated Show resolved Hide resolved
src/components/challenge-category-grid.tsx Outdated Show resolved Hide resolved
@DaMrNelson
Copy link
Contributor Author

Thank you for the feedback! This was my first ever TypeScript and I'm still realtively new to React so the feedback is super valuable to me! I lack a professional environment to get feedback like this normally. I also definitely felt myself getting sloppy with the prop drilling and in general near the end of the day and am happy to wake up to some improvements!

All suggestions have been implemented.

@marcalexiei marcalexiei mentioned this pull request Sep 1, 2024
Open
@DaMrNelson DaMrNelson closed this Sep 4, 2024
@DaMrNelson DaMrNelson reopened this Sep 4, 2024
@DaMrNelson DaMrNelson closed this Sep 4, 2024
@DaMrNelson DaMrNelson reopened this Sep 4, 2024
@DaMrNelson
Copy link
Contributor Author

Sorry, new to GitHub PR system and messing with things.

@DaMrNelson
Copy link
Contributor Author

@tjosepo Soooo we meging this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tjosepo tjosepo tjosepo approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@DaMrNelson @tjosepo