Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

npm*: add Dutch translation and fix more information #14064

Merged
merged 4 commits into from
Oct 9, 2024
Merged

npm*: add Dutch translation and fix more information #14064

merged 4 commits into from
Oct 9, 2024

Conversation

sebastiaanspeck
Copy link
Member

  • The page(s) are in the correct platform directories: common, linux, osx, windows, sunos, android, etc.
  • The page(s) have at most 8 examples.
  • The page description(s) have links to documentation or a homepage.
  • The page(s) follow the content guidelines.
  • The page(s) follow the style guide.
  • The PR title conforms to the recommended templates.

@github-actions github-actions bot added new command Issues requesting creation of a new page. page edit Changes to an existing page(s). translation Translate pages from one language to another. labels Oct 8, 2024
@sebastiaanspeck
Copy link
Member Author

sebastiaanspeck commented Oct 8, 2024 •
edited
Loading

I renamed npm run to npm run-script since that is the official command.

@spageektti spageektti requested a review from Managor October 8, 2024 16:10
@Managor
Copy link
Collaborator

Managor commented Oct 8, 2024

The official npm documentation seems to refer to npm run-script only as a formality
https://docs.npmjs.com/cli/v9/using-npm/scripts#npm-run-user-defined
https://docs.npmjs.com/cli/v9/commands/npm-run-script
I would prefer to keep npm run as the main page, but I won't push back if you disagree.

@sebastiaanspeck
Copy link
Member Author

The official npm documentation seems to refer to npm run-script only as a formality docs.npmjs.com/cli/v9/using-npm/scripts#npm-run-user-defined docs.npmjs.com/cli/v9/commands/npm-run-script I would prefer to keep npm run as the main page, but I won't push back if you disagree.

I was surprised npm run-script is the "official" command as well. I'm fine by keeping npm run, but then I would suggest adding npm run-script as an alias for npm run.

@Managor
Copy link
Collaborator

Managor commented Oct 8, 2024

It's waiting for merging

@sebastiaanspeck sebastiaanspeck changed the title npm*: add Dutch translation, correct npm run-script alias npm*: add Dutch translation, add npm run-script as alias Oct 8, 2024
@tldr-bot

This comment was marked as off-topic.

Sign in to view
leonvsc
leonvsc approved these changes Oct 8, 2024
View reviewed changes
Copy link
Collaborator

@leonvsc leonvsc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Translations looks fine to me!

@Managor Managor changed the title npm*: add Dutch translation, add npm run-script as alias npm*: add Dutch translation and fix more information Oct 8, 2024
@sebastiaanspeck sebastiaanspeck merged commit 5facc6b into tldr-pages:main Oct 9, 2024
4 checks passed
@sebastiaanspeck sebastiaanspeck deleted the npm-nl branch November 5, 2024 12:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@spageektti spageektti spageektti approved these changes

@Managor Managor Managor approved these changes

@leonvsc leonvsc leonvsc approved these changes

@Waples Waples Awaiting requested review from Waples Waples is a code owner

Assignees
No one assigned
Labels
new command Issues requesting creation of a new page. page edit Changes to an existing page(s). translation Translate pages from one language to another.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@sebastiaanspeck @Managor @tldr-bot @leonvsc @spageektti