-
-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
jq: update page #14841
jq: update page #14841
Conversation
The build for this PR failed with the following error(s):
Please fix the error(s) and push again. |
Did you address my review comments? |
I didn't see your comments, could you please tag me again? |
@jxu pinging you since this PR is waiting for your review. If there will be no response within a week, we will merge this. |
I already gave a review. It is up to the author to address my comments. I don't see a way to link them so the only thing I can say is scroll up on the issue tracker. The only comment I have really is to define what "multi-conditional" means. I guess it means combining conditions with AND or OR. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Resubmit review
> More information: <https://jqlang.github.io/jq/manual/>. | ||
|
||
- Execute a specific expression (print a colored and formatted JSON output): | ||
|
||
`{{cat path/to/file.json}} | jq '.'` | ||
|
||
- Execute a specific expression only using the `jq` binary (print a colored and formatted JSON output): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I guess we shouldn't have a redundant example just to show the file input, although it is useful. I'll see what the other reviewers say. Related #13668
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this one or the first example needs to delete, it is basically the same, just different way of stdin controller.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I prefer to keep the second example. The cat-page should show us that this is possible. Not in a non-related page. If someone never views jq, they will never know. It is more likely they will view cat, and then see the |
example.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't feel strongly either way. @vanvuvuong maybe keep the second example and we can get it merged and fix it later if it needs to be
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
updated
I just updated all based on new comments. |
common
,linux
,osx
,windows
,sunos
,android
, etc.