eject: add page #2291
Merged
eject: add page #2291
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mfrw
requested changes
Sep 2, 2018
agnivade
requested changes
Sep 3, 2018
pages/linux/eject.md
Outdated
|
|
||
| `eject` | ||
|
|
||
| - Eject a specific device: |
There was a problem hiding this comment.
In this case, what does it eject ? CD, floppy or tape ? We should mention that.
There was a problem hiding this comment.
It's ordered as:
cd-rom, scsi, floppy and tape
There was a problem hiding this comment.
Let's mention that in parentheses.
sbrl
approved these changes
Sep 3, 2018
|
Perhaps also mention a concrete value for {{device}} ? |
|
@agnivade, sure. Sorry, somehow I missed your comment before. |
|
Umm, sorry if I wasn't clear. I actually meant for all the examples. :P |
|
@agnivade, Ah, whoops. Should I do different ones for each? Like, Or just do all of them as |
|
/dev/cdrom is fine. |
agnivade
approved these changes
Sep 5, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #2214
The page (if new), does not already exist in the repo.
The page (if new), has been added to the correct platform folder:
common/if it's common to all platforms,linux/if it's Linux-specific, and so on.The page has 8 or fewer examples.
The PR is appropriately titled:
<command name>: add pagefor new pages, or<command name>: <description of changes>for pages being edited.The page follows the contributing guidelines.