nologin: add page #2943
Merged
nologin: add page #2943
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sync from upstream
schneiderl
requested changes
Apr 23, 2019
|
This PR is in support of #2214 |
mebeim
requested changes
Apr 25, 2019
There was a problem hiding this comment.
Thank you for the page @lbonanomi, just got a minor change below.
Also, please avoid referencing issues in separate comments, you should do that in the text of your PR instead since you know about it up-front. This way it's easier to see and to keep track of it. I edited it for you this time.
Co-Authored-By: lbonanomi <5369016+lbonanomi@users.noreply.github.com>
mebeim
approved these changes
Apr 25, 2019
sbrl
reviewed
Apr 25, 2019
Co-Authored-By: lbonanomi <5369016+lbonanomi@users.noreply.github.com>
sbrl
approved these changes
Apr 25, 2019
schneiderl
approved these changes
Apr 25, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
common/,linux/, etc.)This PR is in support of #2214.