Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update CI.yml #168

Merged
merged 1 commit into from
May 31, 2024
Merged

Update CI.yml #168

merged 1 commit into from
May 31, 2024

Conversation

kimikage
Copy link
Contributor

@kimikage kimikage commented May 29, 2024

This adds x86 (32-bit) and aarch64 systems to the test targets.

The test fails on 32-bit systems.
One of the problems is that Inflate.jl (for DEFLATE images) may not work on 32-bit systems. (It seems to pass the TiffImages.jl's test, though.) Edit: Fixed by GunnarFarneback/Inflate.jl#21.
Another problem is the LZW handling of TiffImages.jl, as the test results show. (see PR #169)

┌ Warning: LZW: expected 27648 bytes, got 3571 bytes
└ @ TiffImages ~/work/TiffImages.jl/TiffImages.jl/src/compression.jl:202
LZW: Test Failed at /home/runner/work/TiffImages.jl/TiffImages.jl/test/runtests.jl:219
  Expression: TiffImages.load(uncompressed) == TiffImages.load(compressed)
   Evaluated: RGB{N0f8}[RGB{N0f8}(1.0,1.0,1.0) RGB{N0f8}(1.0,1.0,1.0) … RGB{N0f8}(1.0,1.0,1.0) RGB{N0f8}(1.0,1.0,1.0); RGB{N0f8}(1.0,1.0,1.0) RGB{N0f8}(1.0,1.0,1.0) … RGB{N0f8}(1.0,1.0,1.0) RGB{N0f8}(1.0,1.0,1.0); … ; RGB{N0f8}(1.0,1.0,1.0) RGB{N0f8}(1.0,1.0,1.0) … RGB{N0f8}(1.0,1.0,1.0) RGB{N0f8}(1.0,1.0,1.0); RGB{N0f8}(1.0,1.0,1.0) RGB{N0f8}(1.0,1.0,1.0) … RGB{N0f8}(1.0,1.0,1.0) RGB{N0f8}(1.0,1.0,1.0)] == RGB{N0f8}[RGB{N0f8}(1.0,0.0,0.0) RGB{N0f8}(1.0,0.0,0.0) … RGB{N0f8}(0.043,0.553,0.039) RGB{N0f8}(0.361,0.757,0.125); RGB{N0f8}(0.506,0.329,0.133) RGB{N0f8}(0.525,0.286,0.0) … RGB{N0f8}(0.996,0.376,0.184) RGB{N0f8}(0.98,0.357,0.306); … ; RGB{N0f8}(0.0,0.0,0.0) RGB{N0f8}(0.0,0.125,0.0) … RGB{N0f8}(0.863,0.396,0.42) RGB{N0f8}(0.863,0.396,0.42); RGB{N0f8}(0.125,0.0,0.0) RGB{N0f8}(0.125,1.0,1.0) … RGB{N0f8}(0.345,0.725,0.059) RGB{N0f8}(0.282,0.722,0.055)]

The last problem I am aware of is "Arbitrary Bit Depth" (recode()). (See PR #170)

codecov/codecov-action@v4 requires CODECOV_TOKEN.

@codecov-commenter
Copy link

codecov-commenter commented May 30, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 93.67%. Comparing base (ee4852f) to head (c1073ae).

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #168      +/-   ##
==========================================
+ Coverage   93.58%   93.67%   +0.08%     
==========================================
  Files          13       13              
  Lines        1169     1122      -47     
==========================================
- Hits         1094     1051      -43     
+ Misses         75       71       -4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@tlnagy tlnagy closed this May 30, 2024
@tlnagy tlnagy reopened this May 30, 2024
.github/workflows/CI.yml Outdated Show resolved Hide resolved
@tlnagy tlnagy merged commit 377bda2 into tlnagy:master May 31, 2024
12 of 14 checks passed
@kimikage kimikage deleted the update_ci_202405 branch May 31, 2024 02:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants