Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(examples): fix examples for alpha.7 release #603

Merged
merged 8 commits into from
Oct 3, 2024
Merged

Conversation

heeckhau
Copy link
Member

No description provided.

@heeckhau heeckhau changed the base branch from main to dev September 25, 2024 12:41
@sinui0
Copy link
Member

sinui0 commented Sep 26, 2024

Is the verification correct and complete? The old examples checked the public key of the notary. Should this now go into the CryptoProvider?

The presentation output includes the attestation. The attestation includes the Notary key which was used for verification. The verifier must check that key is one they trust.

Is it OK to use "sent_unsafe" the way I did in the Verifier?

Yes. unsafe is present in the signature because the returned data contains both authenticated and unauthenticated data

session_id is no longer part of attestations?

It was removed, instead the AttestationHeader contains an id field which is a random uid

pub id: Uid,

@heeckhau heeckhau marked this pull request as ready for review October 1, 2024 18:11
+ Use secp256k1 key for notary server fixture
+ fix tower issue
+ Fixed doctes issues (Avoid doc test failures when ignored tests are run)
+ Run wasm tests in incognitto mode to avoid chromiumoxide ws errors
@heeckhau heeckhau linked an issue Oct 2, 2024 that may be closed by this pull request
@heeckhau heeckhau added this to the Alpha7 milestone Oct 2, 2024
@sinui0 sinui0 changed the title Fix Alpha7 examples fix(examples): fix examples for alpha.7 release Oct 3, 2024
@sinui0 sinui0 merged commit dfc1629 into dev Oct 3, 2024
5 checks passed
@sinui0 sinui0 deleted the alpha7-examples branch October 3, 2024 03:39
This was referenced Oct 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update examples
3 participants