-
Notifications
You must be signed in to change notification settings - Fork 69
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: supports reading config values from CLI #605
base: dev
Are you sure you want to change the base?
Conversation
you can the server with various options:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Amazing stuff! That was really fast since I just put up the issue yesterday, thanks a lot! Just a few comments :)
…es instead, removes validations in settings.rs
Sorry @yuroitaki I meant to refactor the commit, I've included the changes you've suggested :) . This commit will load the config.yaml and can also override with |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Almost there!
…m string and restores &cli_fields.config_file path and debug log
…emoves unnecessary whitespaces
This PR works on issue #604.
I using the config-rs library to combine the configs in the
main.rs
fileI also set default values in the
settings.rs
file