-
Notifications
You must be signed in to change notification settings - Fork 69
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(wasm): expose presentation verifying key #617
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
error[E0599]: no method named `verifying_key` found for struct `tlsn_core::presentation::Presentation` in the current scope
--> crates/wasm/src/types.rs:248:16
|
248 | self.0.verifying_key().into()
| ^^^^^^^^^^^^^ method not found in `Presentation`
Actually got a compilation error, I tried to change it to self.0.attestation.body.verifying_key()
but then attestation is a private field:
error[E0616]: field `attestation` of struct `tlsn_core::presentation::Presentation` is private
--> crates/wasm/src/types.rs:248:16
|
248 | self.0.attestation.body.verifying_key().into()
| ^^^^^^^^^^^ private field
Was this build caching or something? |
tlsn/crates/core/src/presentation.rs Lines 57 to 60 in 00ed0f9
|
Ahh i guess it was. i nuked everything and now it builds. Also verified the wasm module locally that it works. |
This PR exposes the verifying key for a presentation so that it can be checked prior to performing verification.