Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cross-validated SL predictions #421

Merged
merged 13 commits into from
Aug 18, 2023
Merged

Cross-validated SL predictions #421

merged 13 commits into from
Aug 18, 2023

Conversation

rachaelvp
Copy link
Member

@rachaelvp rachaelvp commented Aug 1, 2023

Cross-validated super learner (function cv_sl) returns the cross-validated predictions for the super learner and its candidates.

@rachaelvp
Copy link
Member Author

rachaelvp commented Aug 1, 2023

Additional changes:

  • Removed kerasR dependancy. We do not appear to be using this package anywhere in sl3 anyway
  • Removed SIS dependency. This was only needed for test-pipeline.R, in testing pipelines with SuperLearner screener "screen.SIS". We do not need this screener to test sl3's pipeline functionality / not worth installing the SIS package in this instance.

@rachaelvp
Copy link
Member Author

I am going to merge this PR soon, as the test errors are not induced by the changes here. Specifically, the build errors are due to (1) a failing test for Lrnr_pca, which I am going to address ASAP, and (2) a failing test for CV that is not occurring locally, which I believe is related Java issues on the GitHub build site

@rachaelvp rachaelvp merged commit fa669c7 into devel Aug 18, 2023
0 of 3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant