Merge devel into master #427
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also, should this really be print()'ed? it comes out looking like: ``` [1] "ARIMA requires matrix of external regressors to not be rank deficient. The following covariates were removed to counter the linear combinations: cnt" ``` Is that intentional? Should it be `cat()`'d, or `message()`'d instead? Lastly, is the intention to print the full message for each of the `rm_idx`? Or maybe this is better: ``` message( "ARIMA requires matrix of external regressors to not be rank ", "deficient. The following covariates were removed to counter the ", "linear combinations: ", toString(names(task$X)[rm_idx]) ) ```
Remove extraneous spaces
Cross-validated SL predictions
Disables use of `kerasR`
Rm impute missings
…passed to learner should match the order of the covariate params, not the order of the covariates in the task
fix subset covariates to support out of order covariates. Covariates …
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
long overdue merge of sl3 devel into master