Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(creator): FFCreatorCenter cannot customize the fileName #459

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

electroluxcode
Copy link

fix #326

在这个代码中

this.copyFromMultipleVal(conf, 'outputDir', 'dir', path.join('./'));

给outputDir设置了一个默认值,导致了下面的代码每次都会进入 if (this.inCenter && outputDir) ,这导致了 output 这个变量永远都会被 uuid 设置,从而用户 实例化的 output永远不生效

FFCreator/lib/creator.js

Lines 99 to 105 in abbbb11

generateOutput() {
const ext = this.getConf('ext');
const outputDir = this.getConf('outputDir');
if (this.inCenter && outputDir) {
this.setOutput(path.join(outputDir, `${Utils.genUuid()}.${ext}`));
}
}

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ffcreate 无法指定输出文件名称
1 participant