Add is-closed? and is-running? functions #104
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is useful to check the state of the connection pool when it's wrapped in a Component (or similar) to avoid issues when trying to close a pool that's already been closed but its instance is still around.
Plus a bunch of improvements:
next.jdbc
Lastly, I'd be more than happy to rewrite all tests to use
clojure.test
- It's probably the first time I'm seeingexpectations
and run into weird issues with it, for example:Given that there's very little difference between:
and
I think it would be a simple refactoring, and one less dependency to worry about.
Lastly,
expectations
has a bunch of reflection warnings - I've enabled them globally inproject.clj