The chasing pet moves at the speed of its friend only if friend is slower #618
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pet now uses speed of friend during chase of friend is slower
sharktrexer
changed the title
previous changes now linted
|
I had forgotten to run "npm run lint:fix" before. Now it should pass the lint test. |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #618 +/- ##
==========================================
- Coverage 17.06% 17.04% -0.02%
==========================================
Files 25 25
Lines 1260 1261 +1
Branches 167 168 +1
==========================================
Hits 215 215
- Misses 1039 1040 +1
Partials 6 6 ☔ View full report in Codecov by Sentry. |
|
Hey @tonybaloney It is been a couple weeks, so I am wondering if I could get an update on this being merged? If there are any other issues for this repo, related to this PR or not, I would love to contribute/help anyway I can. Thank you for your time! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix for #585
Alternative to #599
From suggestion 2: The chasing pet moves at the speed of it's friend - https://github.com/sharktrexer/vscode-pets/blob/main/src/panel/states.ts#L357-L367
Pets now use the slower friend's speed. I assumed it made more sense for only faster pets to move slower rather than slower pets moving faster. I can make a change for slower pets to keep with with faster pets if desired.