Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move LoadImage logic to Rust-side of FFI #16

Merged
merged 34 commits into from
Oct 16, 2024
Merged

Move LoadImage logic to Rust-side of FFI #16

merged 34 commits into from
Oct 16, 2024

Conversation

toolCHAINZ
Copy link
Owner

Replaced Image with the combination of an ImageFFI structure for C++-land and an ImageProvider trait for rust consumers.

This allows using sleigh with both owned and borrowed data.

@toolCHAINZ toolCHAINZ added enhancement New feature or request jingle_sleigh Involves the sleigh FFI labels Oct 16, 2024
@toolCHAINZ toolCHAINZ self-assigned this Oct 16, 2024
This was linked to issues Oct 16, 2024
Consider Moving LoadImage logic to Rust side of FFI boundary #15
Closed
SleighContextBuild set_image with &[u8] slice without copy #7
Closed
@toolCHAINZ toolCHAINZ merged commit e467441 into dev Oct 16, 2024
1 check passed
@toolCHAINZ toolCHAINZ deleted the image_trait branch October 16, 2024 15:55
@toolCHAINZ toolCHAINZ mentioned this pull request Oct 16, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@toolCHAINZ toolCHAINZ

Labels
enhancement New feature or request jingle_sleigh Involves the sleigh FFI
Projects
None yet
Milestone
No milestone
1 participant
@toolCHAINZ