Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Restructured roswww webserver #18

Closed
wants to merge 3 commits into from
Closed

Restructured roswww webserver #18

wants to merge 3 commits into from

Conversation

jihoonl
Copy link
Member

@jihoonl jihoonl commented Jan 15, 2015

@130s

  • classfy roswww webserver
  • remove ros runtime dependency. No roscore is required.

To execute

./roswww/scripts/webserver.py --port 8081 --webpath www

@130s
Copy link
Contributor

130s commented Jan 15, 2015

Looks like a well-thought refactoring is going on. A few questions before moving on:

  • Where was roscore used?

  • sudo is now required right? This itself sounds like a right step.

    • However, sudo being mandatory no longer (easily) allows rosrun (maybe related). Being able to run roswww server as a ROS node was quite handy from launch file.
  • Import glitch?

    $ sudo ./roswww/script/webserver.py --port 8081 -webpath ~/cws_viz/src/tork-a/visualization_rwt/rwt_moveit/www
    [sudo] password for pastabasta: 
    Traceback (most recent call last):
    File "./roswww/script/webserver.py", line 39, in <module>
      import roswww
    ImportError: No module named roswww
    

@130s
Copy link
Contributor

130s commented Jan 15, 2015

Where was roscore used?https

This is what #9 talks about I believe.

@130s 130s closed this Jan 15, 2015
@130s
Copy link
Contributor

130s commented Jan 15, 2015

@jihoonl since I removed the target branch (hydro-devel), github automatically closed this PR and never lets me reopen. Can you open a new PR against develop?

@jihoonl
Copy link
Member Author

jihoonl commented Jan 16, 2015

I have created PR to develop
#19

@jihoonl
Copy link
Member Author

jihoonl commented Jan 16, 2015

Looks like a well-thought refactoring is going on. A few questions before moving on:

  • Where was roscore used?

I believe roscore was required to use rosparam and ros logger. This is why I replaced that with command arguments and python default logger library as #9 explains. I think runtime ros isn't necessary to start roswww server.

  • sudo is now required right? This itself sounds like a right step.
    • However, sudo being mandatory no longer (easily) allows rosrun (maybe related).

sudo is not required to run roswwwserver. You can just execute script to start webserver just as you can run nodejs webserver without sudo permission.

Being able to run roswww server as a ROS node was quite handy from launch file.

Still we can utilise roslaunch in a bit different way. I have updated to add example launch. https://github.com/tork-a/roswww/blob/classfy/launch/roswww.launch

  • Import glitch?

What is it?

$ sudo ./roswww/script/webserver.py --port 8081 -webpath ~/cws_viz/src/tork-a/visualization_rwt/rwt_moveit/www
[sudo] password for pastabasta: 
Traceback (most recent call last):
  File "./roswww/script/webserver.py", line 39, in <module>
    import roswww
ImportError: No module named roswww

webpath is not a root of webserver. it is web page root of each package directory. For example,
the default is www. So roswww webserver looks for www directory for each package and add them into webserver handler. Later I would like to implement #19

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants