pkp/pkp-lib#9899 removed direct mocking of job class

touhidurabir · Oct 25, 2024 · dfa7b6e · dfa7b6e
1 parent 16519d5
commit dfa7b6e
Showing 1 changed file with 6 additions and 15 deletions.
diff --git a/tests/jobs/doi/DepositIssueTest.php b/tests/jobs/doi/DepositIssueTest.php
@@ -98,27 +98,18 @@ public function testRunSerializedJob(): void
 
         app()->instance(DoiRepository::class, $doiRepoMock);
 
+        /** @var \PKP\context\Context $contextMock */
         $contextMock = Mockery::mock(get_class(Application::getContextDAO()->newDataObject()))
             ->makePartial()
             ->shouldReceive('getData')
             ->getMock();
 
-        $depositIssueMock = Mockery::mock(DepositIssue::class, [
-            0, $contextMock, new \PKP\tests\support\DoiRegistrationAgency()
-        ])
-            ->shouldReceive('handle')
-            ->withAnyArgs()
-            ->andReturn(null)
-            ->getMock();
+        $depositIssueMock = new DepositIssue(
+            0,
+            $contextMock,
+            new \PKP\tests\support\DoiRegistrationAgency()
+        );
 
-        /**
-         * @disregard P1013 PHP Intelephense error suppression
-         *
-         * @see https://github.com/bmewburn/vscode-intelephense/issues/568
-         *
-         *  As mock defined it should receive `handle`,
-         *  we will have `handle` method on mock object
-         */
         $this->assertNull($depositIssueMock->handle());
     }
 }