-
Notifications
You must be signed in to change notification settings - Fork 764
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: support uppercase letters in entrypoint names #1286
base: master
Are you sure you want to change the base?
Conversation
Traefik supports entrypoints with uppercase letters (e.g. webSecure), but helm generated manifest fails to apply because port names can only be lowercase. This forces lower case on port names for entrypoints.
Added test to show the issue this patch fixes. |
Hey there! Thanks for your contribution. I have two questions/suggestions:
|
Our entrypoint is currently defined as We can of course automate the change on the running cluster and add a mutation hook to fix incoming objects, but ideally we could perform helm migration without this, since it's a valid entrypoint name at least from the traefik's prospective. As per the second point, adjusting the name to the lower case at least brings the Maybe some sort of name sanitizer would be even better, but IMHO lowering the case improves the current state iteratively and simple enough change that can be merged now. Further improvement could build on top of it. |
What does this PR do?
Traefik supports entrypoints with uppercase letters (e.g. webSecure), but helm generated manifest fails to apply because port names can only be lowercase.
This forces lower case on port names for entrypoints.
Motivation
We are migrating traefik deployment from raw yaml files to helm chart, but one of our entrypoints has uppercase letter in the name (
webSecure
).This issue prevents the migration since helm generates invalid pod template with port name based on entrypoint name with uppercase letter.
From Kubertes Docs:
More
make test
and all the tests passed