feat: 💥 support http redirections and http challenges with cert-manager #934
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Thanks for your contribution to Traefik helm chart.
It's more common with Traefik to use TLS-ALPN-01 with Traefik ACME provider or DNS challenge of cert-manager.
Having that said, this implementation is too specific for many users.
What do you think about changing
ports:
web:
redirectTo: websecureto:
ports:
web:
redirectTo:
port: websecure
priority: 10?
|
@darkweaver87 |
mloiseleur
changed the title
mloiseleur
changed the title
mloiseleur
requested changes
Oct 16, 2023
There was a problem hiding this comment.
@renebarbosafl For users using dns challenges and this redirect, it will fail unless they set a priority.
=> priority should be an optional settings
|
Ok @mloiseleur! |
mloiseleur
approved these changes
Oct 17, 2023
mxmxchere
pushed a commit
to mxmxchere/terraform-hcloud-kube-hetzner
that referenced
this pull request
Oct 23, 2023
Traefik Chart v25.0.0 was released with a breaking change (traefik/traefik-helm-chart#934). This is a quick fix to pin to the old behaviour. Signed-off-by: Malte Muench <muench@b1-systems.de>
mxmxchere
added a commit
to mxmxchere/terraform-hcloud-kube-hetzner
that referenced
this pull request
Oct 23, 2023
Traefik Chart v25.0.0 was released with a breaking change (traefik/traefik-helm-chart#934). This is a quick fix to pin to the old behaviour. Signed-off-by: Malte Muench <muench@b1-systems.de>
mxmxchere
added a commit
to mxmxchere/terraform-hcloud-kube-hetzner
that referenced
this pull request
Oct 23, 2023
Traefik Chart v25.0.0 was released with a breaking change (traefik/traefik-helm-chart#934). This is a quick fix to pin to the old behaviour. Signed-off-by: Malte Münch <muench@b1-systems.de>
robkooper
added a commit
to ncsa/radiant-cluster
that referenced
this pull request
Oct 23, 2023
h3mmy
added a commit
to h3mmy/bloopySphere
that referenced
this pull request
Oct 27, 2023
traefik/traefik-helm-chart#934 Signed-off-by: Zee Aslam <zeet6613@gmail.com>
This was referenced Nov 2, 2023
BasixKOR
added a commit
to BasixCloud/terraform
that referenced
this pull request
May 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
We found that when using the HTTP redirections feature (to force usage of HTTPS) all cert-manager challenges to issue new certificates are failing, this PR adds a new priority parameter that actually enables Traefik to work with cert-manager even if using HTTP redirections.
This helm chart does not have any tests on enabling this feature either so I added it.
Motivation
The solution was found here:
https://community.traefik.io/t/solved-http-to-https-redirect-ends-in-an-https-url-with-8443-appended/10136/5
(Thanks to matthiasbaldi)
More
make testand all the tests passed