feat: allow update of namespace policy for websecure listener #949
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
renebarbosafl
changed the title
darkweaver87
approved these changes
Nov 2, 2023
There was a problem hiding this comment.
LGTM
BTW I think we should allow some users to specify Selector policy (cf. https://gateway-api.sigs.k8s.io/concepts/api-overview/).
As of now, we can only specify All or Same with this code ...
What do you think about it ? It's not related to your PR but if it makes sense for you (how about you @mloiseleur ?) I'll open a PR after yours will be merged.
mloiseleur
approved these changes
Nov 6, 2023
|
@darkweaver87 I agree with you that this Chart should allow to specify selector. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Complement #927
Motivation
Allow updating namespace policy when defining certificates on kubernetesGateway (enabling a listener for websecure entrypoint).
More
make testand all the tests passed