-
Notifications
You must be signed in to change notification settings - Fork 765
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: 💥 unify plugin import between traefik and this chart #961
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mloiseleur
changed the title
Bugfix/plugin import 953
feat: unify plugin import between traefik and this chart
Nov 10, 2023
mloiseleur
added
kind/enhancement
New feature or request
contributor/waiting-for-feedback
labels
Nov 10, 2023
Thanks for this PR ! |
darkweaver87
force-pushed
the
bugfix/plugin_import_953
branch
2 times, most recently
from
November 23, 2023 09:16
92995d4
to
bad3af6
Compare
mloiseleur
approved these changes
Nov 23, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Thanks @darkweaver87 for adding the tests.
mloiseleur
changed the title
feat: unify plugin import between traefik and this chart
feat: 💥 unify plugin import between traefik and this chart
Nov 23, 2023
darkweaver87
force-pushed
the
bugfix/plugin_import_953
branch
from
November 23, 2023 10:00
56c2b14
to
673c693
Compare
mloiseleur
approved these changes
Nov 23, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LTTM
mloiseleur
added
status/3-needs-merge
and removed
contributor/waiting-for-feedback
labels
Dec 1, 2023
traefiker
force-pushed
the
bugfix/plugin_import_953
branch
from
December 1, 2023 16:32
673c693
to
cd3e3a3
Compare
2 tasks
2 tasks
This was referenced Jan 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Fix issue #953
Motivation
need it
More
Only syntax test with https://helm-playground.com
Result not tested...