Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: 💥 unify plugin import between traefik and this chart #961

Merged
merged 5 commits into from
Dec 1, 2023

Conversation

mysiki
Copy link
Contributor

@mysiki mysiki commented Nov 9, 2023

What does this PR do?

Fix issue #953

Motivation

need it

More

Only syntax test with https://helm-playground.com
Result not tested...

@mloiseleur mloiseleur changed the title Bugfix/plugin import 953 feat: unify plugin import between traefik and this chart Nov 10, 2023
@mloiseleur
Copy link
Contributor

Thanks for this PR !
It needs also some tests, to be sure it will be kept in the future.

@darkweaver87 darkweaver87 force-pushed the bugfix/plugin_import_953 branch 2 times, most recently from 92995d4 to bad3af6 Compare November 23, 2023 09:16
Copy link
Contributor

@mloiseleur mloiseleur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks @darkweaver87 for adding the tests.

@mloiseleur mloiseleur changed the title feat: unify plugin import between traefik and this chart feat: 💥 unify plugin import between traefik and this chart Nov 23, 2023
@darkweaver87 darkweaver87 force-pushed the bugfix/plugin_import_953 branch from 56c2b14 to 673c693 Compare November 23, 2023 10:00
Copy link
Contributor

@mloiseleur mloiseleur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LTTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants