Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: 🐛 improve confusing suggested value on openTelemetry.grpc #969

Merged
merged 1 commit into from
Nov 27, 2023
Merged

fix: 🐛 improve confusing suggested value on openTelemetry.grpc #969

merged 1 commit into from
Nov 27, 2023

Conversation

mloiseleur
Copy link
Contributor

What does this PR do?

Set correct suggested value on tracing.openTelemetry.grpc for Traefik v3

Motivation

Fixes #963

darkweaver87
darkweaver87 approved these changes Nov 27, 2023
View reviewed changes
Copy link
Contributor

@darkweaver87 darkweaver87 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@traefiker traefiker merged commit 6a6efc1 into traefik:master Nov 27, 2023
1 check passed
@mloiseleur mloiseleur deleted the fix/otel-grpc branch December 4, 2023 15:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@darkweaver87 darkweaver87 darkweaver87 approved these changes

Assignees
No one assigned
Labels
kind/bug/fix
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Setting tracing.openTelemetry.grpc via values.yaml not working
3 participants
@mloiseleur @darkweaver87 @traefiker