little improvement of translator ach.po #3253

taufiqsumadi · 2016-11-06T09:29:14Z

I found some bugs:

Different whitespace at the end
missing variable
Different XML tags
Different functions
Different whitespace at the end
Different numbers
I hope some improvements can be helpful ;) @julen

I found some bugs: 1. Different whitespace at the end 2. missing variable 3. Different XML tags 4. Different functions 5. Different whitespace at the end 6. Different numbers I hope some improvements can be helpful ;)

Different numbers and different quotation.

Different whitespace at the end, and different quotation marks.

jayvdb

I am just highlighting changes that the maintainers should focus on.

jayvdb · 2016-11-07T01:47:38Z

po/cs.po

@@ -1115,7 +1115,7 @@ msgstr "Další..."
 #: ../virtaal/plugins/spellchecker.py:361
 #, python-format
 msgid "Add \"%s\" to Dictionary"
-msgstr "Přidat „%s“ do slovníku"
+msgstr "Přidat \"%s\" do slovníku"


This change needs to be reviewed carefully. Maybe smart quotes are better.

Quoting styles are language specific. This looks perfectly correct for cs. Likely you ran pofilter with specifying a language as there are language specific adaptation.

jayvdb · 2016-11-07T01:47:56Z

po/cs.po

@@ -1142,7 +1142,7 @@ msgstr "Vyberte služby které chcete použít pro vyhledávání"
 #: ../virtaal/plugins/lookup/lookupview.py:131
 #, python-format
 msgid "Look-up \"%(selection)s\""
-msgstr "Vyhledat „%(selection)s“"
+msgstr "Vyhledat \"%(selection)s\""


smart quotes again

jayvdb · 2016-11-07T01:48:03Z

po/cs.po

@@ -1303,7 +1303,7 @@ msgstr "Všechny soubory"
 #: ../virtaal/plugins/terminology/models/localfile/localfileview.py:256
 #, python-format
 msgid "\"%s\" is not a usable file."
-msgstr "„%s“ není použitelný soubor."
+msgstr "\"%s\" není použitelný soubor."


smart quotes again

jayvdb · 2016-11-07T01:48:16Z

po/cs.po

@@ -2300,11 +2300,11 @@ msgstr "provede profilování, výsledek uloží do zadaného souboru."

 #: ../bin/virtaal:135
 msgid "Could not open log file '%(filename)s'"
-msgstr "Soubor záznamu ‚%(filename)s‘ se nepodařilo otevřít"
+msgstr "Soubor záznamu '%(filename)s' se nepodařilo otevřít"


smart quotes again

jayvdb · 2016-11-07T01:48:21Z

po/cs.po


 #: ../bin/virtaal:143
 msgid "Could not read configuration file '%(filename)s'"
-msgstr "Konfigurační soubor ‚%(filename)s‘ se nepodařilo načíst"
+msgstr "Konfigurační soubor '%(filename)s' se nepodařilo načíst"


smart quotes again

jayvdb · 2016-11-07T01:48:27Z

po/cs.po

@@ -2316,7 +2316,7 @@ msgstr "Profilování není podporováno"

 #: ../bin/virtaal:185
 msgid "Could not open profile file '%(filename)s'"
-msgstr "Profilovací soubor ‚%(filename)s‘ se nepodařilo otevřít"
+msgstr "Profilovací soubor '%(filename)s' se nepodařilo otevřít"


smart quotes again

jayvdb · 2016-11-07T01:49:09Z

po/it.po

@@ -463,21 +463,21 @@ msgstr ""
 #: ../virtaal/tips.py:31
 msgid "To mark the current translation as fuzzy, simply press <Alt+U>."
 msgstr ""
-"Per segnare la presente traduzione come \"fuzzy\", basta premere <Alt+U>."
+"Per segnare la presente traduzione come fuzzy, basta premere <Alt+U>."


Adding quotes around English words is fairly common in translations.

The translator is highlighting that the word fuzzy here is untranslated or borrowed, so leave the quotes. The quotes checker is a guide not a hard and fast rule. This we'd consider a false positive.

jayvdb · 2016-11-07T01:49:55Z

po/it.po


 #: ../virtaal/tips.py:32
 msgid ""
 "To mark the current translation as incomplete, simply press <Ctrl+Shift"
 "+Enter>."
 msgstr ""
-"Per segnare la presente traduzione come \"incompleta\", basta premere <Ctrl"


interesting change; perhaps the source string should have quotes around it.

jayvdb · 2016-11-07T01:50:13Z

po/it.po

 "+Shift+Enter>."

 # 75%
 #: ../virtaal/tips.py:33
 msgid "To mark the current translation as complete, simply press <Ctrl+Enter>."
 msgstr ""
-"Per segnare la presente traduzione come \"completa\", basta premere <Ctrl"


likewise quotes in the source string might be helpful.

dwaynebailey

We use technical failures to indicate issues in the translated text. By cleaning these up and not having a translator clean them up we lost some of these markers.

That said the patch is fine to land with some fixes.

There are only one or two quotes fixes that are correct. '' -> " is correct. The others are different quote styles or using quotes in the target. Those are all fine.

Trailing whitespace and punctuation fixes can land.

Fixing is risky in that there could be bigger issues, but they can land.

Fixing variables. The usually all need fixing. The %s one is easy as its almost always an issue. The %filename is harder as we don't know how the language works in terms of prefixing such words. But all those can land.

Thanks for the patch, there are some good fixes here.

dwaynebailey · 2016-11-07T09:19:50Z

po/cs.po

@@ -2015,7 +2015,7 @@ msgstr "<b>%d</b>"
 #: ../virtaal/views/propertiesview.py:203
 #, python-format
 msgid "%.1f KB"
-msgstr "%.1f kB"
+msgstr "%.1f KB"


The ACRONYM filter is dumb. It is simply flagging potential errors. kB is perfectly correct in some locales, in fact our source could be considered incorrect.

dwaynebailey · 2016-11-07T09:21:21Z

po/cs.po

@@ -2039,7 +2039,7 @@ msgstr "O jeden krok workflow vpřed (Ctrl+Enter)"

 #: ../virtaal/views/widgets/aboutdialog.py:34
 msgid "Copyright © 2007-2010 Zuza Software Foundation"
-msgstr "Copyright © 2007-2011 Zuza Software Foundation"
+msgstr "Copyright © 2007-2010 Zuza Software Foundation"


I wouldn't worry about this number as its part of a date range. Likely the source should say 2007-2016. So its OK to land, just not critical and not more correct.

dwaynebailey · 2016-11-07T09:22:38Z

po/it.po

@@ -449,7 +449,7 @@ msgid ""
 "At the end of a translation, simply press <Enter> to continue with the next "
 "one."
 msgstr ""
-"Alla fine della traduzione, premere semplicemente <Invio> per continuare con "
+"Alla fine della traduzione, premere semplicemente <Enter> per continuare con "


The problem with correcting any of these 'XML' is that they probably need a review of the whole string from a language perspective. Lets land this one, but be aware that you don't know the software enough to know if someone has just reused another string.

dwaynebailey · 2016-11-07T09:23:44Z

po/it.po

@@ -463,21 +463,21 @@ msgstr ""
 #: ../virtaal/tips.py:31
 msgid "To mark the current translation as fuzzy, simply press <Alt+U>."
 msgstr ""
-"Per segnare la presente traduzione come \"fuzzy\", basta premere <Alt+U>."
+"Per segnare la presente traduzione come fuzzy, basta premere <Alt+U>."


The translator is highlighting that the word fuzzy here is untranslated or borrowed, so leave the quotes. The quotes checker is a guide not a hard and fast rule. This we'd consider a false positive.

dwaynebailey · 2016-11-07T09:23:54Z

po/it.po


 #: ../virtaal/tips.py:32
 msgid ""
 "To mark the current translation as incomplete, simply press <Ctrl+Shift"
 "+Enter>."
 msgstr ""
-"Per segnare la presente traduzione come \"incompleta\", basta premere <Ctrl"


taufiqsumadi added 3 commits November 6, 2016 04:22

little improvement of translator ach.po

77cf8f6

I found some bugs: 1. Different whitespace at the end 2. missing variable 3. Different XML tags 4. Different functions 5. Different whitespace at the end 6. Different numbers I hope some improvements can be helpful ;)

little improvement of translator cs.po

6ebaa84

Different numbers and different quotation.

little improvement of translator it.po

e22cd0a

Different whitespace at the end, and different quotation marks.

jayvdb reviewed Nov 7, 2016

View reviewed changes

dwaynebailey requested changes Nov 7, 2016

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

little improvement of translator ach.po #3253

little improvement of translator ach.po #3253

taufiqsumadi commented Nov 6, 2016

jayvdb left a comment

jayvdb Nov 7, 2016

dwaynebailey Nov 7, 2016

jayvdb Nov 7, 2016

jayvdb Nov 7, 2016

jayvdb Nov 7, 2016

jayvdb Nov 7, 2016

jayvdb Nov 7, 2016

jayvdb Nov 7, 2016

dwaynebailey Nov 7, 2016

jayvdb Nov 7, 2016

dwaynebailey Nov 7, 2016

jayvdb Nov 7, 2016

dwaynebailey left a comment

dwaynebailey Nov 7, 2016

dwaynebailey Nov 7, 2016

dwaynebailey Nov 7, 2016

dwaynebailey Nov 7, 2016

dwaynebailey Nov 7, 2016

little improvement of translator ach.po #3253

Are you sure you want to change the base?

little improvement of translator ach.po #3253

Conversation

taufiqsumadi commented Nov 6, 2016

jayvdb left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

dwaynebailey left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment