Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Merging tusharpm's use-bash #6

Open
wants to merge 5 commits into
base: default
Choose a base branch
from
Open

Merging tusharpm's use-bash #6

wants to merge 5 commits into from

Conversation

meatballhat
Copy link

No description provided.

tusharpm and others added 4 commits February 19, 2017 23:20
@tusharpm
Fix apt source problem
0feb038 
- apt-add-repository adds the binaries repository, and misses the sources entry
- Add the -s flag to apt-add-repository to add the deb-src entry
- Reduce the repetition of the same command.
@tusharpm
Bash equivalent for add_sources.rb Ruby script
77c3571 
- use jq for JSON processing
- use bash-builtins for processing the output
- retain the same logic as the Ruby script
@meatballhat
Merge branch 'use-bash' of https://github.com/tusharpm/apt-whitelist-…
cb312ba 
…checker into tusharpm-use-bash
@meatballhat
Modifications on top of #5 ❤️
6543b48
@meatballhat meatballhat self-assigned this Jul 18, 2017
@meatballhat meatballhat requested a review from BanzaiMan July 18, 2017 02:38
@meatballhat
Copy link
Author

@BanzaiMan AFAICT the default branch is not passing otherwise, and is fairly diverged from the run branch which is passing, so I'm not sure how to proceed 😐

@tusharpm tusharpm mentioned this pull request Jul 18, 2017
Open
tusharpm
tusharpm reviewed Jul 18, 2017
View reviewed changes
build.sh Outdated
IFS=${old_IFS}
cd "${HOME}"
curl -sSL "${APT_SOURCE_WHITELIST_UBUNTU_JSON}" \
| jq -r '.[] | [.alias, .sourceline, .key_url] | join(" ")' \

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

@AraHaan
Copy link

AraHaan commented Dec 17, 2017

uh for some reason the bot did not make the branch or the pull request yet for the libc++-dev issue I opened for the whitelist.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tusharpm tusharpm tusharpm left review comments

@BanzaiMan BanzaiMan Awaiting requested review from BanzaiMan

Assignees

@meatballhat meatballhat

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@meatballhat @AraHaan @tusharpm