Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix lakectl upload with pre-sign for Azure #6660

Merged
merged 6 commits into from
Oct 10, 2023
Merged

Fix lakectl upload with pre-sign for Azure #6660

merged 6 commits into from
Oct 10, 2023

Conversation

guy-har
Copy link
Contributor

@guy-har guy-har commented Sep 28, 2023

No description provided.

@guy-har guy-har added the include-changelog PR description should be included in next release changelog label Sep 28, 2023
@guy-har guy-har linked an issue Sep 28, 2023 that may be closed by this pull request
Azure pre-signed URLs sometimes use expired credentials #6643
Closed
N-o-Z
N-o-Z requested changes Sep 28, 2023
View reviewed changes
Copy link
Member

@N-o-Z N-o-Z left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The code looks good though I do have 2 questions:

  1. How does this resolve Azure pre-signed URLs sometimes use expired credentials #6643 (which was already closed by another PR)
  2. Can we add tests that cover this scenario

@guy-har guy-har removed a link to an issue Oct 1, 2023
Azure pre-signed URLs sometimes use expired credentials #6643
Closed
@guy-har guy-har linked an issue Oct 1, 2023 that may be closed by this pull request
[Bug]: Lakectl Azure: fs upload with --pre-sign url fails #6426
Closed
@nopcoder
Copy link
Contributor

nopcoder commented Oct 1, 2023

Removing myself as @N-o-Z already on it.

@nopcoder nopcoder removed their request for review October 1, 2023 14:12
@guy-har guy-har requested a review from N-o-Z October 10, 2023 11:12
@guy-har
Copy link
Contributor Author

guy-har commented Oct 10, 2023

@N-o-Z Changed the connected issue and added tests as requested. The tests required a few more changes, and I opened the following issues as part of it
#6743 #6744 #6745
PTAL

N-o-Z
N-o-Z approved these changes Oct 10, 2023
View reviewed changes
Copy link
Member

@N-o-Z N-o-Z left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@guy-har Thanks - can you please link / open the correct issue for this PR?

@guy-har
Copy link
Contributor Author

guy-har commented Oct 10, 2023

@guy-har Thanks - can you please link / open the correct issue for this PR?
@N-o-Z what's wrong with the current issue? (#6426 )

@N-o-Z
Copy link
Member

N-o-Z commented Oct 10, 2023

@guy-har Thanks - can you please link / open the correct issue for this PR?
@N-o-Z what's wrong with the current issue? (#6426 )

Nothing :)
Originally it was linked to an unrelated issue

@guy-har guy-har merged commit c0d5d31 into master Oct 10, 2023
30 checks passed
@guy-har guy-har deleted the fix/lakect-azure-presign branch October 10, 2023 12:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@N-o-Z N-o-Z N-o-Z approved these changes

Assignees
No one assigned
Labels
include-changelog PR description should be included in next release changelog
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Bug]: Lakectl Azure: fs upload with --pre-sign url fails
3 participants
@guy-har @nopcoder @N-o-Z