-
Notifications
You must be signed in to change notification settings - Fork 350
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix lakectl upload with pre-sign for Azure #6660
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The code looks good though I do have 2 questions:
- How does this resolve Azure pre-signed URLs sometimes use expired credentials #6643 (which was already closed by another PR)
- Can we add tests that cover this scenario
651d394
to
794470b
Compare
Removing myself as @N-o-Z already on it. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@guy-har Thanks - can you please link / open the correct issue for this PR?
No description provided.