Pull Requests: Create swagger spec #8168
Conversation
N-o-Z
added
exclude-changelog
|
♻️ PR Preview 48679e6 has been successfully destroyed since this PR has been closed.
🤖 By surge-preview |
E2E Test Results - DynamoDB Local - Local Block Adapter |
E2E Test Results - Quickstart |
N-o-Z
force-pushed
the
task/pulls-create-swagger-8167
branch
from
bf02d4d
to
61c150c
Compare
N-o-Z
force-pushed
the
task/pulls-create-swagger-8167
branch
from
61c150c
to
6792b70
Compare
This reverts commit 6792b70.
|
Actual changed files:
All the rest are auto generated code |
pkg/api/controller.go
Outdated
| writeResponse(w, r, http.StatusNotImplemented, nil) | ||
| } | ||
|
|
||
| func (c *Controller) DeletePullRequest(w http.ResponseWriter, r *http.Request, repository string, pullRequest string) { |
There was a problem hiding this comment.
Should be repositoryID and pullRequestID.
Also relevant for GetPullRequest and UpdatePullRequest.
There was a problem hiding this comment.
For repository our convention in all other functions is repository
I'll update pullRequest
| - in: path | ||
| name: repository | ||
| required: true | ||
| schema: |
There was a problem hiding this comment.
What about description?
There was a problem hiding this comment.
Pretty straightforward, I don't think repository needs any elaboration
| description: too many requests | ||
| default: | ||
| $ref: "#/components/responses/ServerError" | ||
| patch: |
There was a problem hiding this comment.
Note that in the Design Issue it's designed different -
But what's written in the PR is far better (hence I think the design should be updated).
Closes #8167
Change Description
Create swagger spec, generated code and controller stubs for pull requests
Background
Epic