Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pull Requests for Data #8235

Merged
merged 7 commits into from
Sep 30, 2024
Merged

Pull Requests for Data #8235

merged 7 commits into from
Sep 30, 2024

Conversation

itaigilo
Copy link
Contributor

Closes #7998.
Closes #8182.


Change Description

Add tests,
And enable the feature in the WebUI.

Copy link

E2E Test Results - DynamoDB Local - Local Block Adapter

13 passed

Copy link

github-actions bot commented Sep 29, 2024

E2E Test Results - Quickstart

11 passed

@itaigilo itaigilo added the include-changelog PR description should be included in next release changelog label Sep 29, 2024
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This reveals PRfD to everyone.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added classes to make elements more discoverable.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For non "pull requests" tests -
It's only about auto-formatting, plus removing some redundant awaits (as wisely suggested by IntelliJ).

@itaigilo itaigilo marked this pull request as ready for review September 29, 2024 15:10
@itaigilo itaigilo closed this Sep 29, 2024
@itaigilo itaigilo reopened this Sep 29, 2024
Comment on lines -63 to -65
{
// TODO (gilo): this is temp, until PRfD will be ready
showPulls &&
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

😄

@itaigilo itaigilo merged commit e52707d into master Sep 30, 2024
38 checks passed
@itaigilo itaigilo deleted the feature/prfd-playwright-and-release branch September 30, 2024 08:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
include-changelog PR description should be included in next release changelog
Projects
None yet
Development

Successfully merging this pull request may close these issues.

PRfD - WebUI - Add Playwright tests Pull Request for Data
2 participants