Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

lakectl local: posix improvements #8257

Merged
merged 3 commits into from
Oct 2, 2024
Merged

lakectl local: posix improvements #8257

merged 3 commits into from
Oct 2, 2024

Conversation

N-o-Z
Copy link
Member

@N-o-Z N-o-Z commented Oct 1, 2024

Add support to ignore UID and/or GID

@N-o-Z N-o-Z added exclude-changelog PR description should not be included in next release changelog minor-change Used for PRs that don't require issue attached labels Oct 1, 2024
@N-o-Z N-o-Z requested a review from a team October 1, 2024 12:11
@N-o-Z N-o-Z self-assigned this Oct 1, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented Oct 1, 2024

E2E Test Results - DynamoDB Local - Local Block Adapter

13 passed

@github-actions GitHub Actions
Copy link

github-actions bot commented Oct 1, 2024 •
edited
Loading

E2E Test Results - Quickstart

10 passed, 1 failed

Test failures:
  Quickstart › pull requests: common/quickstart.spec.ts

quickstart.spec.ts:102:9 pull requests


[quickstart] › common/quickstart.spec.ts:102:9 › Quickstart › pull requests ──────────────────────


Test timeout of 30000ms exceeded.

Error: locator.click: Test timeout of 30000ms exceeded.
Call log:
  - waiting for locator('#pulls-tabs-tab-closed')


   at poms/pullsPage.ts:44

  42 |
  43 |     async gotoPullsTab(id: string): Promise<void> {
> 44 |         await this.page.locator(`#pulls-tabs-tab-${id}`).click();
     |                                                          ^
  45 |     }
  46 |
  47 |     async getFirstPullsRowDetails(): Promise<{title: string, description: string}> {

    at PullsPage.gotoPullsTab (/home/runner/work/lakeFS/lakeFS/webui/test/e2e/poms/pullsPage.ts:44:58)
    at /home/runner/work/lakeFS/lakeFS/webui/test/e2e/common/quickstart.spec.ts:142:25

attachment #1: trace (application/zip) ─────────────────────────────────────────────────────────
test-results/common-quickstart-Quickstart-pull-requests-quickstart/trace.zip
Usage:

    npx playwright show-trace test-results/common-quickstart-Quickstart-pull-requests-quickstart/trace.zip

────────────────────────────────────────────────────────────────────────────────────────────────
This test report was produced by the test-summary action.  Made with ❤️ in Cambridge.

itaigilo
itaigilo approved these changes Oct 2, 2024
View reviewed changes
Copy link
Contributor

@itaigilo itaigilo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great, nice and clean.

Approving to unblock -
But please check the comment.

cmd/lakectl/cmd/local.go Outdated
@@ -71,6 +71,8 @@ func localDiff(ctx context.Context, client apigen.ClientWithResponsesInterface,
changes, err := local.DiffLocalWithHead(currentRemoteState, path, local.Config{
SkipNonRegularFiles: cfg.Local.SkipNonRegularFiles,
IncludePerm: cfg.Experimental.Local.POSIXPerm.Enabled,
IncludeUID: cfg.Experimental.Local.POSIXPerm.IncludeUID,
IncludeGID: cfg.Experimental.Local.POSIXPerm.IncludeUID,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this IncludeUID and not IncludeGID on purpose?

9Same q for the other files of course.)

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks - good catch!

@N-o-Z N-o-Z enabled auto-merge (squash) October 2, 2024 17:50
@N-o-Z N-o-Z merged commit c939d71 into master Oct 2, 2024
36 of 37 checks passed
@N-o-Z N-o-Z deleted the task/lakectl-posix-improvements branch October 2, 2024 18:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@itaigilo itaigilo itaigilo approved these changes

Assignees

@N-o-Z N-o-Z

Labels
exclude-changelog PR description should not be included in next release changelog minor-change Used for PRs that don't require issue attached
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@N-o-Z @itaigilo