-
Notifications
You must be signed in to change notification settings - Fork 350
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
lakectl local: posix improvements #8257
Conversation
E2E Test Results - Quickstart
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great, nice and clean.
Approving to unblock -
But please check the comment.
cmd/lakectl/cmd/local.go
Outdated
@@ -71,6 +71,8 @@ func localDiff(ctx context.Context, client apigen.ClientWithResponsesInterface, | |||
changes, err := local.DiffLocalWithHead(currentRemoteState, path, local.Config{ | |||
SkipNonRegularFiles: cfg.Local.SkipNonRegularFiles, | |||
IncludePerm: cfg.Experimental.Local.POSIXPerm.Enabled, | |||
IncludeUID: cfg.Experimental.Local.POSIXPerm.IncludeUID, | |||
IncludeGID: cfg.Experimental.Local.POSIXPerm.IncludeUID, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this IncludeUID
and not IncludeGID
on purpose?
9Same q for the other files of course.)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks - good catch!
Add support to ignore UID and/or GID