Give cargo-dist a try-out #352
Conversation
Signed-off-by: Darach Ennis <darach@gmail.com>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #352 +/- ##
=======================================
Coverage 36.43% 36.43%
=======================================
Files 8 8
Lines 409 409
=======================================
Hits 149 149
Misses 260 260 ☔ View full report in Codecov by Sentry. |
| push: | ||
| tags: | ||
| - '**[0-9]+.[0-9]+.[0-9]+*' | ||
| pull_request: |
There was a problem hiding this comment.
I don't think we want to run this on every pull request
There was a problem hiding this comment.
It skips for PRs when its configured for plan mode and doesn't generate artefacts. There is another mode that always builds release artefacts but I disabled it. The default mode is plan. If you look at our CI output for this PR you'll see plan was triggered and it skipped the release distribution process.
There was a problem hiding this comment.
Here's the reference in the docs:
https://opensource.axo.dev/cargo-dist/book/introduction.html#distributing
My read of that is that until we push a tag it does nothing. Our release process adds a tag so it should only fire on release for us with no other configuration.
There was a problem hiding this comment.
Interesting, that's complex but lets give it a shot 👍
Signed-off-by: Darach Ennis darach@gmail.com