New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

(2) Extract complex strings #2

Open

trishrempel wants to merge 1 commit into basic-extraction from complex-extraction

Owner

trishrempel commented Jun 12, 2023 •

edited

Loading

This pull request performs some complex string extraction with variable interpolation, interpolation with React components, and pluralization.

Demonstrated localizing a single string in UK English.
Extracted the names of the file types for translation.
Extracted the formatted file type string as separate keys instead of using variable interpolation (avoided the DRY rule to produce better translations).
Demonstrated pluralization with the formatted quantity string.
Extracted a string with React elements passed as interpolation variables using the <Trans /> component

trishrempel force-pushed the basic-extraction branch from 33c0e77 to b18dc2e Compare

June 12, 2023 04:41


          Extract complex strings

0c26823

trishrempel force-pushed the complex-extraction branch from 23cd564 to 0c26823 Compare

June 12, 2023 04:42

trishrempel changed the title ~~Extract complex strings~~ (2) Extract complex strings

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet