Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP: Library interface dev #19

Draft
wants to merge 32 commits into
base: main
Choose a base branch
from
Draft

WIP: Library interface dev #19

wants to merge 32 commits into from

Conversation

DavidAKopriva
Copy link
Collaborator

No description provided.

Move string constants from individual modules to the ProgramGlobal module.
Move control for 3D generation to a dictionary in the MeshProject so that that all that the full control dictionary is not needed to generate  3D meshes.
Key off of new member property for gernating a 3D mesh.
Proof of concept for API access to HOHQMesh
API routines for creation, deletion and meshing. Stubs for future calls.
@codecov
Copy link

codecov bot commented Jun 21, 2021

Codecov Report

Merging #19 (1f0ef3d) into main (375ac98) will decrease coverage by 0.04%.
The diff coverage is 40.81%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main      #19      +/-   ##
==========================================
- Coverage   57.41%   57.36%   -0.05%     
==========================================
  Files          65       65              
  Lines        9557     9591      +34     
==========================================
+ Hits         5487     5502      +15     
- Misses       4070     4089      +19     
Flag Coverage Δ
unittests 57.36% <40.81%> (-0.05%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
Source/3DSource/3DMeshController.f90 0.00% <0.00%> (-4.00%) ⬇️
Source/3DSource/SimpleSweep.f90 0.00% <ø> (ø)
Source/3DSource/SweeperClass.f90 0.00% <ø> (ø)
Source/Project/Model/SMModel.f90 58.45% <ø> (ø)
Source/HOHQMesh.f90 53.70% <25.00%> (-2.38%) ⬇️
Source/Project/MeshProject.f90 67.37% <29.16%> (-0.72%) ⬇️
Source/IO/MeshOutputMethods.f90 69.72% <66.66%> (-0.06%) ⬇️
Source/Mesh/MeshGeneratorMethods.f90 77.64% <100.00%> (+0.13%) ⬆️
Source/MeshObjects/SMMeshObjects.f90 62.18% <100.00%> (+0.18%) ⬆️
... and 1 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 375ac98...1f0ef3d. Read the comment docs.

@DavidAKopriva DavidAKopriva marked this pull request as draft June 21, 2021 16:28
@DavidAKopriva DavidAKopriva changed the title Library interface dev WIP:Library interface dev Jun 21, 2021
Add accessors that return simple arrays of the node locations, element connectivity and edgeInfo needed for the ISM-v2 format.
Add bind(C) to procedures.
Remove file that is replaced by LibObjectAccessors
Add framework for testing the interactive API.
Add a start to the interactive API documentation.
Add two error constants
Move conversion of cPtr to project pointer to a subroutine. Add errorFlag to the accessor methods.
Add accessors for boundary values. Remaining to write: Boundary names
Minor other edits. Mostly documentation update.
Add accessor method for the boundary curve names.
Instead of accessing a file with the expected values, get them directly from the project.
Add test of boundary names. Fix some  "possible" uninitialized variable errors.
Add Set/Get for plot file name
Just some formatting.
@sloede sloede changed the title WIP:Library interface dev WIP: Library interface dev Jul 11, 2021
Add some documentation
Add code and tests for C access to FTDictionary and FTLinkedList objects, with a minimal subset of methods to allow creation of a project dictionary "from outside".
Factor the code a bit. Add header comments with lists of procedures in each file. Add subroutine for initWithDictionary where the dictionary is a cPtr.
Add array to dictionary for use with spline data.
Change New to Alloc and Close to release to better describe the actions. Add forgotten BIND(C) to procedures.
Start creating wrappers for the fortran library access.
Close opened files before exiting write routines.
Add more wrapper functions to the Julia. Add the ABAQUS format to the setter for the mesh file format.
Add some string accessors.
Fix bug in Lib where object is not defined. Adjust formatting for printing a projectDictionary. Add conversion of Julia project dictionary to an FTOL one.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant