Fix cucumber_opts warning #1736
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for this, just checked it on my machine, seems to do the trick! If you rebase against master the rubocop failure will go away and we can merge this one ;) |
troessner
approved these changes
Oct 10, 2023
I was reading the [Developing Reek Contributing](https://github.com/JuanVqz/reek?tab=readme-ov-file#developing-reek--contributing) to understand how `reek` works, then run the `rake console` and saw the `warning` message. ```ruby ➜ reek git:(master) be rake console WARNING: consider using an array rather than a space-delimited string with cucumber_opts to avoid undesired behavior. BEFORE ➜ reek git:(master) rg cucumber_opts . ./tasks/test.rake 21: t.cucumber_opts = 'features --format progress --color' AFTER ➜ reek git:(master) rg cucumber_opts . ./tasks/test.rake 21: t.cucumber_opts = ['features --format', 'progress --color'] ```
JuanVqz
force-pushed
the
fix-cucumber_opts-warning
branch
from
d4b480c
to
f8dbffc
Compare
|
@troessner rebased! |
troessner
approved these changes
Oct 10, 2023
|
Thanks, @JuanVqz! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I was reading the Developing Reek Contributing
to understand how
reekworks, then run therake consoleand saw thewarningmessage.after making it an array the
warningwas gone, let's see if that works for you.