Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NAS-133090 / 25.04 / Migrate some instances of viewChild #11187

Merged
merged 2 commits into from
Dec 17, 2024
Merged

Conversation

undsoft
Copy link
Collaborator

@undsoft undsoft commented Dec 15, 2024

Testing:

Check for regressions.

@undsoft undsoft requested a review from a team as a code owner December 15, 2024 19:35
@undsoft undsoft requested review from denysbutenko and removed request for a team December 15, 2024 19:35
@bugclerk bugclerk changed the title NAS-133090: Migrate some instances of viewChild NAS-133090 / 25.04 / Migrate some instances of viewChild Dec 15, 2024
@bugclerk
Copy link
Contributor

Copy link

codecov bot commented Dec 16, 2024

Codecov Report

Attention: Patch coverage is 79.10448% with 42 lines in your changes missing coverage. Please review.

Project coverage is 82.70%. Comparing base (19789f4) to head (9d04f1d).
Report is 8 commits behind head on master.

✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
...ion/replication-form/replication-form.component.ts 50.00% 11 Missing ⚠️
.../directory-service/directory-services.component.ts 0.00% 9 Missing ⚠️
...-dialog/error-template/error-template.component.ts 0.00% 8 Missing ⚠️
...ms/components/ix-combobox/ix-combobox.component.ts 83.33% 2 Missing ⚠️
...ix-forms/components/ix-input/ix-input.component.ts 33.33% 2 Missing ⚠️
...omponents/global-search/global-search.component.ts 75.00% 2 Missing ⚠️
...terminal/components/terminal/terminal.component.ts 0.00% 2 Missing ⚠️
src/app/pages/vm/vm-wizard/vm-wizard.component.ts 88.23% 2 Missing ⚠️
...replication-wizard/replication-wizard.component.ts 75.00% 1 Missing ⚠️
...oard/components/line-chart/line-chart.component.ts 50.00% 1 Missing ⚠️
... and 2 more
Additional details and impacted files
@@           Coverage Diff           @@
##           master   #11187   +/-   ##
=======================================
  Coverage   82.69%   82.70%           
=======================================
  Files        1652     1652           
  Lines       58316    58385   +69     
  Branches     6011     6011           
=======================================
+ Hits        48224    48285   +61     
- Misses      10092    10100    +8     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@denysbutenko denysbutenko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@undsoft undsoft merged commit 863eae6 into master Dec 17, 2024
9 checks passed
@undsoft undsoft deleted the NAS-133090 branch December 17, 2024 09:18
@bugclerk
Copy link
Contributor

This PR has been merged and conversations have been locked.
If you would like to discuss more about this issue please use our forums or raise a Jira ticket.

@truenas truenas locked as resolved and limited conversation to collaborators Dec 17, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants